Do not set advanced options with empty string to true #4977
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are advanced options such as force-local that expect an empty string in some cases. While saving, these were replaced with
true
even though there was an equals sign. Now only options without an equals sign are set to true.The options were not set to
true
when opening the configuration but already when saving, so the saved backup configuration was different than in the UI.Closes #4757
Old behavior
Set flags and empty values to true before saving:
--dry-run
=>--dry-run=true
--force-locale=
=>--force-locale=true
New behavior
Set flags to true (as before):
--dry-run
=>--dry-run=true
Keep empty options with empty value:
--force-locale=
=>--force-locale=